kbandla / dpkt / 564

100%

Pull #325

travis-ci

Do circular imports in icmp and icmp6 modules correctly (Issue #324)

There are circular deps between ip.py and icmp.py/icmp6.py modules.
Because of alphabetical imports in __init__.py, the icmp modules
are imported before ip.py, but they both need ip.py and ip.py during
initialization tries to import these icmp.

Because of these circular imports, icmp and icmp6 data in IP packets
weren't parsed correctly (#324). This patch does the imports in
slightly better fashion, so parsing of ICMP packets in IP works
again.

2 of 2 new or added lines in 2 files covered. (100.0%)

6021 of 7078 relevant lines covered (85.07%)

0.85 hits per line