aws / aws-codedeploy-agent / 119

pending completion

Build # 119

Build Type

push

travis-ci

Committed by

ambareesha

Commit Message

Revert "Changed the way we untar a tar bundle to avoid the security vulnaribility"

This reverts commit c4cf46195.

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

4116 of 4349 relevant lines covered (94.64%)

9.34 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

63.83

/lib/instance_agent/platform/linux_util.rb

module InstanceAgent
  class LinuxUtil
    def self.supported_versions()
      [0.0]
    end

    def self.supported_oses()
      ['linux']
    end

    def self.prepare_script_command(script, absolute_cmd_path)
      runas = !!script.runas
      sudo = !!script.sudo

      if runas && sudo
        return 'sudo su ' + script.runas + ' -c ' + absolute_cmd_path
      end

      if runas && !sudo
        return 'su ' + script.runas + ' -c ' + absolute_cmd_path
      end

      if !runas && sudo
        return 'sudo ' + absolute_cmd_path
      end

      # If neither sudo or runas is specified, execute the
      # command as the code deploy agent user 
      absolute_cmd_path
    end

    def self.quit()
      # Send kill signal to parent and exit
      Process.kill('TERM', Process.ppid)
    end

    def self.script_executable?(path)
      File.executable?(path)
    end

    def self.extract_tar(bundle_file, dst)
      FileUtils.mkdir_p(dst)
      execute_tar_command("/bin/tar -xpsf #{bundle_file} -C #{dst}")
    end

    def self.extract_tgz(bundle_file, dst)
      FileUtils.mkdir_p(dst)
      execute_tar_command("/bin/tar -zxpsf #{bundle_file} -C #{dst}")
    end

    def self.supports_process_groups?()
      true
    end

    def self.codedeploy_version_file
      File.join(ProcessManager::Config.config[:root_dir], '..')
    end

    def self.fallback_version_file
      "/opt/codedeploy-agent"
    end
    
    private
    def self.execute_tar_command(cmd)
      log(:debug, "Executing #{cmd}")

      output = `#{cmd} 2>&1`
      exit_status = $?.exitstatus

      log(:debug, "Command status: #{$?}")
      log(:debug, "Command output: #{output}")

      if exit_status != 0
        msg = "Error extracting tar archive: #{exit_status}"
        log(:error, msg)
        raise msg
      end
    end

    private
    def self.log(severity, message)
      raise ArgumentError, "Unknown severity #{severity.inspect}" unless InstanceAgent::Log::SEVERITIES.include?(severity.to_s)
      InstanceAgent::Log.send(severity.to_sym, "#{self.to_s}: #{message}")
    end

  end
end

1	module InstanceAgent	1✔
2	class LinuxUtil	1✔
3	def self.supported_versions()	1✔
4	[0.0]	×
5	end
6
7	def self.supported_oses()	1✔
8	['linux']	119✔
9	end
10
11	def self.prepare_script_command(script, absolute_cmd_path)	1✔
12	runas = !!script.runas	13✔
13	sudo = !!script.sudo	13✔
14
15	if runas && sudo	13✔
16	return 'sudo su ' + script.runas + ' -c ' + absolute_cmd_path	1✔
17	end
18
19	if runas && !sudo	12✔
20	return 'su ' + script.runas + ' -c ' + absolute_cmd_path	3✔
21	end
22
23	if !runas && sudo	9✔
24	return 'sudo ' + absolute_cmd_path	1✔
25	end
26
27	# If neither sudo or runas is specified, execute the
28	# command as the code deploy agent user
29	absolute_cmd_path	8✔
30	end
31
32	def self.quit()	1✔
33	# Send kill signal to parent and exit
34	Process.kill('TERM', Process.ppid)	×
35	end
36
37	def self.script_executable?(path)	1✔
38	File.executable?(path)	10✔
39	end
40
41	def self.extract_tar(bundle_file, dst)	1✔
42	FileUtils.mkdir_p(dst)	×
43	execute_tar_command("/bin/tar -xpsf #{bundle_file} -C #{dst}")	×
44	end
45
46	def self.extract_tgz(bundle_file, dst)	1✔
47	FileUtils.mkdir_p(dst)	×
48	execute_tar_command("/bin/tar -zxpsf #{bundle_file} -C #{dst}")	×
49	end
50
51	def self.supports_process_groups?()	1✔
52	true	5✔
53	end
54
55	def self.codedeploy_version_file	1✔
56	File.join(ProcessManager::Config.config[:root_dir], '..')	3✔
57	end
58
59	def self.fallback_version_file	1✔
60	"/opt/codedeploy-agent"	2✔
61	end
62
63	private	1✔
64	def self.execute_tar_command(cmd)	1✔
65	log(:debug, "Executing #{cmd}")	×
66
67	output = `#{cmd} 2>&1`	×
68	exit_status = $?.exitstatus	×
69
70	log(:debug, "Command status: #{$?}")	×
71	log(:debug, "Command output: #{output}")	×
72
73	if exit_status != 0	×
74	msg = "Error extracting tar archive: #{exit_status}"	×
75	log(:error, msg)	×
76	raise msg	×
77	end
78	end
79
80	private	1✔
81	def self.log(severity, message)	1✔
82	raise ArgumentError, "Unknown severity #{severity.inspect}" unless InstanceAgent::Log::SEVERITIES.include?(severity.to_s)	×
83	InstanceAgent::Log.send(severity.to_sym, "#{self.to_s}: #{message}")	×
84	end
85
86	end
87	end

aws / aws-codedeploy-agent / 119

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous