zendframework / zend-expressive / 1011

97%

Pull #402

travis-ci

Make PHP error handler operate in a stack

Per #400, when we register a new error handler to swallow deprecation
notices in `Application::__invoke()`, if any global error handlers were
registered previously, they now disappear.

This patch adds a test covering that scenario, and updates the
`Application` class as follows:

- The `set_error_handler()` call in `Application::__invoke()` has been
  replaced with a call to a new method, `swallowDeprecationNotices()`.
- `swallowDeprecationNotices()` now captures the return value of calling
  `set_error_handler()`; if that value is non-empty, it creates a new
  error handler closing over its own error handler and the previous
  which invokes the previous if our own returns false.

14 of 14 new or added lines in 1 file covered. (100.0%)

511 of 538 relevant lines covered (94.98%)

11.75 hits per line