mongodb / mongo-php-driver / 1599

90%

master: 87%

Pull #481

travis-ci

PHPC-848: Consult ZEND_HASH_APPLY_PROTECTION() in PHP7

When a numeric array was encoded to BSON, the hash's apply counter was incremented and decremented irrespective of whether apply protection was enabled. This was not compatible with immutable arrays, which may be created by OPcache. We now consult ZEND_HASH_APPLY_PROTECTION() whenever an apply counter might be modified.

Previously, object_to_bson() incremented the apply counter when converting a MongoDB\BSON\Type instance. Associative arrays and other objects were not protected. This patch adds recursion checking for those types.

Since PHP7 already has macros for working with the apply counter, this patch adds equivalent macros for PHP 5.x.

18 of 18 new or added lines in 1 file covered. (100.0%)

3103 of 3463 relevant lines covered (89.6%)

2790.01 hits per line