decentraland / social-service-ea / 24455772176

90%

main: 90%

Build Type

Pull #407

github

Committed by kevinszuchet

Commit Message

fix: add cork wrapping, subscriber metrics, reconciliation, and sScan

Hardening changes to complement the critical OOM fixes:

1. Wrap all HTTP responses in res.cork() to prevent uWS warnings about
   writes outside corked callbacks. Under GC pressure these interleaved
   writes can hold object references longer than necessary.

2. Add subscriber monitoring metrics (gauges): subscribers_local_count,
   subscribers_generators_count, subscribers_redis_set_size, and a
   subscribers_stale_cleaned counter. Reported every 30s via setInterval.

3. Add periodic stale subscriber reconciliation (every 5 min, configurable
   via SUBSCRIBER_RECONCILIATION_INTERVAL_MS). Cross-references local
   subscribers against active WS connections from wsPool and removes any
   orphaned subscribers that the cleanup path missed.

4. Replace redis.sMembers() with redis.client.sScanIterator() in
   getSubscribersAddresses() to avoid loading the entire Redis SET at
   once. Adds a warning log when the set exceeds 10,000 entries.

5. Add redis.sCard() for O(1) subscriber count metric reporting.
6. Add wsPool.getAuthenticatedAddresses() for reconciliation.

Pull Request Pull Request #407: fix: prevent OOM crashes from subscriber leak and duplicate subscriptions

Coverage Stats

2220 of 2615 branches covered (84.89%)

Branch coverage included in aggregate %.

70 of 122 new or added lines in 7 files covered. (57.38%)

2 existing lines in 1 file now uncovered.

5472 of 5971 relevant lines covered (91.64%)

71.43 hits per line