decentraland / social-service-ea / 24449911581

90%

main: 90%

Build Type

Pull #407

github

Committed by kevinszuchet

Commit Message

fix: prevent OOM crashes from subscriber leak and duplicate subscriptions

Three critical fixes for the heap exhaustion crash (510 MB after ~62h):

1. Fix cleanup bug in ws-handler: the three cleanup steps (transport.close,
   detachUser, emitter.clear) were in a single try/catch. If transport.close()
   threw (uWS throws on closed sockets), detachUser and emitter.clear were
   skipped, permanently leaking the subscriber's emitter and generators.
   Each step is now an independent function with its own error handling.

2. Guard against duplicate subscriptions: clients can call the same stream
   RPC multiple times on one connection. Each call created another async
   generator with a 1000-item value queue, doubling memory per connection.
   Crash logs confirmed this for communityMemberConnectivityUpdate.
   Added per-(address, event) deduplication in handleSubscriptionUpdates.

3. Set explicit V8 heap limit (768 MB for 1024 MB prod containers) via
   NODE_OPTIONS env var in Dockerfile, overridable at deploy time.

Pull Request Pull Request #407: fix: prevent OOM crashes from subscriber leak and duplicate subscriptions

Coverage Stats

2217 of 2596 branches covered (85.4%)

Branch coverage included in aggregate %.

31 of 36 new or added lines in 3 files covered. (86.11%)

28 existing lines in 2 files now uncovered.

5453 of 5909 relevant lines covered (92.28%)

71.79 hits per line