tarantool
/
tarantool
/
23217155027
88%
master: 88%
master: 88%
|
Ran
|
Jobs
1
|
Files
514
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 87.655% (-0.007%) from 87.662%
push
github
Gerold103election: drop promotion flag before entering Raft box_promote() used to keep is_in_box_promote flag while running box_raft_try_promote(). Sometimes this led to the Raft worker being too fast, entering box_promote_qsync(), and failing on is_in_box_promote being set. Even though it is literally a part of the same promote. Lets drop the flag right before entering box_raft_try_promote(). Both before and after the behaviour is really the same. Just previously the Raft worker had to retry the limbo promotion. The difference is only detectable in the logs. This is why there is also no special test for this. The existing ones cover the guards completely fine. Closes #12333 NO_DOC=bugfix NO_CHANGELOG=too minor and no behaviour changes (cherry picked from commit 0cae9f838)
69832 of 117631 branches covered (59.37%)
2 of 2 new or added lines in 1 file covered. (100.0%)
307 existing lines in 16 files now uncovered.104822 of 119585 relevant lines covered (87.65%)
1387560.92 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 259 |
91.39 |
0.37% | src/box/box.cc |
| 15 |
94.35 |
-0.18% | src/box/txn_limbo.c |
| 7 |
87.88 |
-0.27% | src/box/vy_run.c |
| 4 |
92.67 |
-0.73% | src/box/xrow_update_field.c |
| 3 |
92.28 |
-0.13% | src/box/vinyl.c |
| 3 |
94.15 |
-1.06% | src/box/vy_range.c |
| 3 |
22.66 |
-0.06% | src/lib/uri/uri_parser.c |
| 2 |
94.66 |
-0.59% | src/box/raft.c |
| 2 |
95.22 |
-0.43% | src/box/txn_limbo_queue.c |
| 2 |
94.19 |
-0.5% | src/box/vy_write_iterator.c |
| 2 |
85.71 |
-9.52% | src/lib/core/tt_sigaction.c |
| 1 |
96.3 |
-0.18% | src/box/relay.cc |
| 1 |
95.72 |
-0.12% | src/box/replication.cc |
| 1 |
80.74 |
-0.33% | src/box/tuple_bloom.c |
| 1 |
84.83 |
-0.11% | src/box/xlog.c |
| 1 |
89.39 |
-1.52% | src/lib/small/small/lsregion.c |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 23217155027.1 | 514 |
87.65 |
GitHub Action Run |
