jordanvrtanoski / luacpp / ab677b8a-c0d9-484c-a8b0-2a4cd882016e

100%

push

circleci

[IMP] Eliminate code duplication and fix critical security issue (#36)

* [IMP] Eliminate code duplication and fix critical security issue

- Add PoolTestUtils.hpp with shared helper functions for library checking
- Refactor TestStatePool.cpp and TestPoolManager.cpp to use shared helpers
- Add findPoolOrThrow() helper in PoolManager to reduce duplicate find+throw logic
- Add AcquireVerifyReleaseThree helper to eliminate remaining test duplication
- Fix critical security issue: getGlobalVariable() no longer returns reference to static null pointer
  - Changed return type from reference to value (thread-safe)
  - Returns nullptr directly instead of static null pointer reference
- Maintain 100% line and function coverage (2784/2784 lines, 684/684 functions)

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>

* [FIX] Use realloc() in custom allocator to avoid CWE-120

Replace manual malloc/memcpy/free with realloc() which is the
standard C function for memory resizing. This eliminates the
buffer overflow concern (CWE-120) entirely as realloc handles
the memory copy internally and safely.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>

* [CI] Add Codacy configuration for Cppcheck with proper include paths

Configure Cppcheck with standard C++ library include paths to eliminate
false positive 'Include file not found' warnings. Also exclude
non-C++ files (.devcontainer, build) from analysis.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>

---------

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>

118 of 118 new or added lines in 7 files covered. (100.0%)

2712 of 2712 relevant lines covered (100.0%)

48.86 hits per line