zendframework / zend-mvc / 392

pending completion

Build # 392

Build Type

Pull #198

travis-ci

Committed by

web-flow

Commit Message

Use a factory to create the SendResponseListener

Reported in:

- zendframework/zend-mvc-console#10
- zendframework/zend-mvc-console#11
- zendframework/zend-mvc-console#12

The `SendResponseListener` was lazy-instantiating an event manager on
first request to `getEventManager()`. However, because initializers run
after delegators, this meant that the EM instance composed did not have
a shared EM instance, which triggered the initializer to re-inject,
losing any listeners injected by delegators.

This patch introduces a factory for the `SendResponseListener`. The
factory creates the instance, and then injects it with an EM instance
pulled from the container; since these are guaranteed to have a shared
EM instance, the initializer will skip injection, keeping any listeners
injected by delegators.

Pull Request Pull Request #198: Use a factory to create the SendResponseListener

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

1555 of 1871 relevant lines covered (83.11%)

10.81 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

79.31

/src/Service/ServiceManagerConfig.php

Build SHA Not Found

The commit SHA "5de8c665bb1c77e6944527cf6fc560a92413363b" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

zendframework / zend-mvc / 392

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous