couchbase / sync_gateway / 251

65%

master: 64%

Build Type

push

jenkins

Committed by web-flow

Commit Message

CBG-4270: Implement sequence-based storage for BlipTesterClient (#7226)

* Implement sequence-based storage for BlipTesterClient

* Add fixmes for the 3 bad tests

* remove accidental test change

* addlicense

* pull out old comments and unrelated changes

* drop more test logging

* drop more test logging

* fix lints

* fix race - not using copied seq value

* Updates based on review/race fixes

* Inherit context, wrap with cancel and pass through to push changes feed - handle broadcast wake on close

* Since btcc.ctx inherits from rt.Context, don't do an explicit check - rely on the context chaining

* Block Close until the push replicator goroutine has exited

* misspell fix

* log around sync cond/locking to diagnose close deadlock

* Fix Close deadlock and remove associated investigation logging

* Replace test client logging with debug and drop assertions in favour of errors and requires

* Reduce nesting - defer channel close

* godoc comments

Run Details

22 of 29 new or added lines in 3 files covered. (75.86%)

15 existing lines in 5 files now uncovered.

36625 of 56152 relevant lines covered (65.22%)

0.74 hits per line