11762267160

Committed 09 Nov 2024 02:39AM UTC coverage: 85.341% (+0.01%) from 85.329%

Build # 11762267160

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Ghost consumers during meta recovery (#6092)

During meta recovery `ru.updateConsumers` and `ru.removeConsumers` would
not be properly cleared since the move from
`map[string]*consumerAssignment` to
`map[string]map[string]*consumerAssignment`. Which meant that consumers
that needed to be removed were both in `ru.removeConsumers` and left in
`ru.updateConsumers`. Resulting in a ghost consumer.

Also don't clear recovering state while we still have items to process
as part of recovery.

De-flakes `TestJetStreamClusterLostConsumers`, and makes
`TestJetStreamClusterConsumerLeak` more reliable by re-introducing the
`ca.pending` flag. Since the consumer leader responds for consumer
creation, but meta leader responds for consumer deletion, so need to
have the consumer assignment available so meta leader can respond
successfully.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

---------

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

67818 of 79467 relevant lines covered (85.34%)

1113014.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.36

/src/github.com/nats-io/nats-server/server/filestore.go

Source Not Available

The file "src/github.com/nats-io/nats-server/server/filestore.go" isn't available on github. Either it's been removed, or the repo root directory needs to be updated.

nats-io / nats-server / 11762267160

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available

Source File
Press 'n' to go to next uncovered line, 'b' for previous