11174118948

Committed 03 Oct 2024 09:40PM UTC coverage: 85.234% (-0.05%) from 85.285%

Build # 11174118948

Build Type

push

github

Committed by

web-flow

Commit Message

(2.11) Don't send meta snapshot when becoming metaleader (#5700)

Antithesis testing has found that late or out-of-order delivery of these
snapshots, likely due to latency or thread pauses, can cause stream
assignments to be reverted which results in assets being deleted and
recreated. There may also be a race condition where the metalayer comes
up before network connectivity to all other nodes is fully established
so we may end up generating snapshots that don't include assets we don't
know about yet.

We will want to audit all uses of `SendSnapshot` as it somewhat breaks
the consistency model, especially now that we have fixed a significant
number of Raft bugs that `SendSnapshot` usage may have been papering
over.

Further Antithesis runs without this code run fine and have eliminated a
number of unexpected calls to `processStreamRemoval`.

We've also added a new unit test
`TestJetStreamClusterHardKillAfterStreamAdd` for a long-known issue, as
well as a couple tweaks to the ghost consumer tests to make them
reliable.

Signed-off-by: Neil Twigg <neil@nats.io>

---------

Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Co-authored-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

66862 of 78445 relevant lines covered (85.23%)

1061294.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.67

/src/github.com/nats-io/nats-server/server/jetstream_events.go

Source Not Available

The file "src/github.com/nats-io/nats-server/server/jetstream_events.go" isn't available on github. Either it's been removed, or the repo root directory needs to be updated.

nats-io / nats-server / 11174118948

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available

Source File
Press 'n' to go to next uncovered line, 'b' for previous