krisleech / wisper / 145

pending completion

Build # 145

Build Type

Pull #46

travis-ci

Committed by

gersmann

Commit Message

Refactor listener accessor to also handle strings

- don't instantiate class from class reference
- also handle string references to subscriber

Pull Request Pull Request #46: Allow 'soft reference' to subscriber by class / class name

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

507 of 514 relevant lines covered (98.64%)

52.82 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.33

/lib/wisper/registration/registration.rb

module Wisper
  class Registration
    attr_reader :on, :listener

    def initialize(listener, options)
      @listener   = listener
      @on         = Array(options.fetch(:on) { 'all' }).map(&:to_s)
    end
    
    def listener
      case @listener
        when Class
          clazz = Kernel.const_get(@listener.to_s)
          clazz.new
        when String
          clazz = Kernel.const_get(@listener)
          clazz.new
        else
          @listener
      end
    end

    private

    def should_broadcast?(event)
      on.include?(event) || on.include?('all')
    end
  end
end

1	module Wisper	6✔
2	class Registration	6✔
3	attr_reader :on, :listener	6✔
4
5	def initialize(listener, options)	6✔
6	@listener = listener	687✔
7	@on = Array(options.fetch(:on) { 'all' }).map(&:to_s)	1,149✔
8	end
9
10	def listener	6✔
11	case @listener	852✔
12	when Class	291 only jruby-19mode, rbx, and jruby-20mode ✔
13	clazz = Kernel.const_get(@listener.to_s)	×
14	clazz.new	×
15	when String	291 only jruby-19mode, rbx, and jruby-20mode ✔
16	clazz = Kernel.const_get(@listener)	×
17	clazz.new	187 only rbx ✔
18	else
19	@listener	852✔
20	end
21	end
22
23	private	6✔
24
25	def should_broadcast?(event)	6✔
26	on.include?(event) \|\| on.include?('all')	340✔
27	end
28	end
29	end

krisleech / wisper / 145

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous