10722680224

Committed 05 Sep 2024 02:42PM UTC coverage: 97.414% (-0.3%) from 97.693%

Build # 10722680224

Build Type

push

github

Committed by

g-saracca

Commit Message

feat: add tests and case when there is no token created

Run Details

1291 of 1346 branches covered (95.91%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 2 files covered. (100.0%)

26 existing lines in 5 files now uncovered.

3456 of 3527 relevant lines covered (97.99%)

9073.19 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

64.1

/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.tsx

import { useTranslation } from 'react-i18next'
import { useNavigate } from 'react-router-dom'
import {
  Dataset,
  DatasetNonNumericVersionSearchParam,
  DatasetPublishingStatus
} from '../../../../dataset/domain/models/Dataset'
import { DropdownButton, DropdownButtonItem } from '@iqss/dataverse-design-system'
import { EditDatasetPermissionsMenu } from './EditDatasetPermissionsMenu'
import { DeleteDatasetButton } from './DeleteDatasetButton'
import { DeaccessionDatasetButton } from './DeaccessionDatasetButton'
import { useNotImplementedModal } from '../../../not-implemented/NotImplementedModalContext'
import { useSession } from '../../../session/SessionContext'
import { QueryParamKey, Route } from '../../../Route.enum'

interface EditDatasetMenuProps {
  dataset: Dataset
}

enum EditDatasetMenuItems {
  FILES_UPLOAD = 'filesUpload',
  METADATA = 'metadata',
  TERMS = 'terms',
  PERMISSIONS = 'permissions',
  PRIVATE_URL = 'privateUrl',
  THUMBNAILS_PLUS_WIDGETS = 'thumbnailsPlusWidgets'
}

export function EditDatasetMenu({ dataset }: EditDatasetMenuProps) {
  const { user } = useSession()
  const { showModal } = useNotImplementedModal()
  const { t } = useTranslation('dataset')
  const navigate = useNavigate()

  const handleOnSelect = (eventKey: EditDatasetMenuItems | string | null) => {
    const searchParams = new URLSearchParams()
    searchParams.set(QueryParamKey.PERSISTENT_ID, dataset.persistentId)

    if (dataset.version.publishingStatus === DatasetPublishingStatus.DRAFT) {
      searchParams.set(QueryParamKey.VERSION, DatasetNonNumericVersionSearchParam.DRAFT)
    }

    if (eventKey === EditDatasetMenuItems.FILES_UPLOAD) {
      navigate(`${Route.UPLOAD_DATASET_FILES}?${searchParams.toString()}`)
      return
    }
    if (eventKey === EditDatasetMenuItems.METADATA) {
      navigate(`${Route.EDIT_DATASET_METADATA}?${searchParams.toString()}`)
      return
    }
    showModal()
  }

  if (!user || !dataset.permissions.canUpdateDataset) {
    return <></>
  }

  return (
    <DropdownButton
      onSelect={handleOnSelect}
      id={`edit-dataset-menu`}
      title={t('datasetActionButtons.editDataset.title')}
      asButtonGroup
      variant="secondary"
      disabled={dataset.checkIsLockedFromEdits(user.persistentId)}>
      <DropdownButtonItem
        eventKey={EditDatasetMenuItems.FILES_UPLOAD}
        as="button"
        disabled={!dataset.hasValidTermsOfAccess}>
        {t('datasetActionButtons.editDataset.filesUpload')}
      </DropdownButtonItem>
      <DropdownButtonItem
        eventKey={EditDatasetMenuItems.METADATA}
        as="button"
        disabled={!dataset.hasValidTermsOfAccess}>
        {t('datasetActionButtons.editDataset.metadata')}
      </DropdownButtonItem>
      <DropdownButtonItem eventKey={EditDatasetMenuItems.TERMS} as="button">
        {t('datasetActionButtons.editDataset.terms')}
      </DropdownButtonItem>
      <EditDatasetPermissionsMenu dataset={dataset} />
      {(dataset.permissions.canManageDatasetPermissions ||
        dataset.permissions.canManageFilesPermissions) && (
        <DropdownButtonItem eventKey={EditDatasetMenuItems.PRIVATE_URL} as="button">
          {t('datasetActionButtons.editDataset.privateUrl')}
        </DropdownButtonItem>
      )}
      <DropdownButtonItem eventKey={EditDatasetMenuItems.THUMBNAILS_PLUS_WIDGETS} as="button">
        {t('datasetActionButtons.editDataset.thumbnailsPlusWidgets')}
      </DropdownButtonItem>
      <DeleteDatasetButton dataset={dataset} />
      <DeaccessionDatasetButton dataset={dataset} />
    </DropdownButton>
  )
}

1	import { useTranslation } from 'react-i18next'
2	import { useNavigate } from 'react-router-dom'
3	import {
4	Dataset,
5	DatasetNonNumericVersionSearchParam,
6	DatasetPublishingStatus
7	} from '../../../../dataset/domain/models/Dataset'
8	import { DropdownButton, DropdownButtonItem } from '@iqss/dataverse-design-system'
9	import { EditDatasetPermissionsMenu } from './EditDatasetPermissionsMenu'
10	import { DeleteDatasetButton } from './DeleteDatasetButton'
11	import { DeaccessionDatasetButton } from './DeaccessionDatasetButton'
12	import { useNotImplementedModal } from '../../../not-implemented/NotImplementedModalContext'
13	import { useSession } from '../../../session/SessionContext'
14	import { QueryParamKey, Route } from '../../../Route.enum'
15
16	interface EditDatasetMenuProps {
17	dataset: Dataset
18	}
19
20	enum EditDatasetMenuItems {	23✔
21	FILES_UPLOAD = 'filesUpload',	23✔
22	METADATA = 'metadata',	23✔
23	TERMS = 'terms',	23✔
24	PERMISSIONS = 'permissions',	23✔
25	PRIVATE_URL = 'privateUrl',	23✔
26	THUMBNAILS_PLUS_WIDGETS = 'thumbnailsPlusWidgets'	23✔
27	}
28
29	export function EditDatasetMenu({ dataset }: EditDatasetMenuProps) {	270✔
30	const { user } = useSession()	270✔
31	const { showModal } = useNotImplementedModal()	270✔
32	const { t } = useTranslation('dataset')	270✔
33	const navigate = useNavigate()	263✔
34
35	const handleOnSelect = (eventKey: EditDatasetMenuItems \| string \| null) => {	263✔
36	const searchParams = new URLSearchParams()	×
37	searchParams.set(QueryParamKey.PERSISTENT_ID, dataset.persistentId)	×
38
UNCOV 39	if (dataset.version.publishingStatus === DatasetPublishingStatus.DRAFT) {	×
40	searchParams.set(QueryParamKey.VERSION, DatasetNonNumericVersionSearchParam.DRAFT)	×
41	}
42
UNCOV 43	if (eventKey === EditDatasetMenuItems.FILES_UPLOAD) {	×
UNCOV 44	navigate(`${Route.UPLOAD_DATASET_FILES}?${searchParams.toString()}`)	×
UNCOV 45	return	×
46	}
UNCOV 47	if (eventKey === EditDatasetMenuItems.METADATA) {	×
UNCOV 48	navigate(`${Route.EDIT_DATASET_METADATA}?${searchParams.toString()}`)	×
UNCOV 49	return	×
50	}
UNCOV 51	showModal()	×
52	}
53
54	if (!user \|\| !dataset.permissions.canUpdateDataset) {	263✔
55	return <></>	242✔
56	}
57
58	return (	21✔
59	<DropdownButton
60	onSelect={handleOnSelect}
61	id={`edit-dataset-menu`}
62	title={t('datasetActionButtons.editDataset.title')}
63	asButtonGroup
64	variant="secondary"
65	disabled={dataset.checkIsLockedFromEdits(user.persistentId)}>
66	<DropdownButtonItem
67	eventKey={EditDatasetMenuItems.FILES_UPLOAD}
68	as="button"
69	disabled={!dataset.hasValidTermsOfAccess}>
70	{t('datasetActionButtons.editDataset.filesUpload')}
71	</DropdownButtonItem>
72	<DropdownButtonItem
73	eventKey={EditDatasetMenuItems.METADATA}
74	as="button"
75	disabled={!dataset.hasValidTermsOfAccess}>
76	{t('datasetActionButtons.editDataset.metadata')}
77	</DropdownButtonItem>
78	<DropdownButtonItem eventKey={EditDatasetMenuItems.TERMS} as="button">
79	{t('datasetActionButtons.editDataset.terms')}
80	</DropdownButtonItem>
81	<EditDatasetPermissionsMenu dataset={dataset} />	46✔
82	{(dataset.permissions.canManageDatasetPermissions \|\|
83	dataset.permissions.canManageFilesPermissions) && (
84	<DropdownButtonItem eventKey={EditDatasetMenuItems.PRIVATE_URL} as="button">
85	{t('datasetActionButtons.editDataset.privateUrl')}
86	</DropdownButtonItem>
87	)}
88	<DropdownButtonItem eventKey={EditDatasetMenuItems.THUMBNAILS_PLUS_WIDGETS} as="button">
89	{t('datasetActionButtons.editDataset.thumbnailsPlusWidgets')}
90	</DropdownButtonItem>
91	<DeleteDatasetButton dataset={dataset} />
92	<DeaccessionDatasetButton dataset={dataset} />
93	</DropdownButton>
94	)
95	}	23✔

IQSS / dataverse-frontend / 10722680224

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous