9988626377

Committed 18 Jul 2024 09:01AM UTC coverage: 64.641% (-1.6%) from 66.257%

Build # 9988626377

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #14496 from rgacogne/coverity-2024-07

dnsdist: Fix/silence Coverity "auto causes copy" warnings

Run Details

37013 of 87914 branches covered (42.1%)

Branch coverage included in aggregate %.

3 of 4 new or added lines in 4 files covered. (75.0%)

65 existing lines in 12 files now uncovered.

124509 of 161963 relevant lines covered (76.87%)

4937421.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

61.9

/pdns/recursordist/rec-tcpout.cc

/*
 * This file is part of PowerDNS or dnsdist.
 * Copyright -- PowerDNS.COM B.V. and its contributors
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
 * published by the Free Software Foundation.
 *
 * In addition, for the avoidance of any doubt, permission is granted to
 * link this program with OpenSSL and to (re)distribute the binaries
 * produced as the result of such linking.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

#include "rec-tcpout.hh"

// This line from /usr/include/openssl/ssl2.h: # define CERT char
// throws dnsrecords.hh off the rails.
#undef CERT

#include "syncres.hh"

timeval TCPOutConnectionManager::s_maxIdleTime;
size_t TCPOutConnectionManager::s_maxQueries;
size_t TCPOutConnectionManager::s_maxIdlePerAuth;
size_t TCPOutConnectionManager::s_maxIdlePerThread;

void TCPOutConnectionManager::cleanup(const struct timeval& now)
{
  if (s_maxIdleTime.tv_sec == 0 && s_maxIdleTime.tv_usec == 0) {
    // no maximum idle time
    return;
  }

  for (auto it = d_idle_connections.begin(); it != d_idle_connections.end();) {
    timeval idle = now - it->second.d_last_used;
    if (s_maxIdleTime < idle) {
      it = d_idle_connections.erase(it);
    }
    else {
      ++it;
    }
  }
}

void TCPOutConnectionManager::store(const struct timeval& now, const ComboAddress& ip, Connection&& connection)
{
  ++connection.d_numqueries;
  if (s_maxQueries > 0 && connection.d_numqueries >= s_maxQueries) {
    return;
  }

  if (d_idle_connections.size() >= s_maxIdlePerThread || d_idle_connections.count(ip) >= s_maxIdlePerAuth) {
    cleanup(now);
  }

  if (d_idle_connections.size() >= s_maxIdlePerThread) {
    return;
  }
  if (d_idle_connections.count(ip) >= s_maxIdlePerAuth) {
    return;
  }

  gettimeofday(&connection.d_last_used, nullptr);
  d_idle_connections.emplace(ip, std::move(connection));
}

TCPOutConnectionManager::Connection TCPOutConnectionManager::get(const ComboAddress& ip)
{
  if (d_idle_connections.count(ip) > 0) {
    auto h = d_idle_connections.extract(ip);
    return h.mapped();
  }
  return Connection{};
}

uint64_t getCurrentIdleTCPConnections()
{
  return broadcastAccFunction<uint64_t>([] { return t_tcp_manager.getSize(); });
}

1	/*
2	* This file is part of PowerDNS or dnsdist.
3	* Copyright -- PowerDNS.COM B.V. and its contributors
4	*
5	* This program is free software; you can redistribute it and/or modify
6	* it under the terms of version 2 of the GNU General Public License as
7	* published by the Free Software Foundation.
8	*
9	* In addition, for the avoidance of any doubt, permission is granted to
10	* link this program with OpenSSL and to (re)distribute the binaries
11	* produced as the result of such linking.
12	*
13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.
17	*
18	* You should have received a copy of the GNU General Public License
19	* along with this program; if not, write to the Free Software
20	* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
21	*/
22
23	#include "rec-tcpout.hh"
24
25	// This line from /usr/include/openssl/ssl2.h: # define CERT char
26	// throws dnsrecords.hh off the rails.
27	#undef CERT
28
29	#include "syncres.hh"
30
31	timeval TCPOutConnectionManager::s_maxIdleTime;
32	size_t TCPOutConnectionManager::s_maxQueries;
33	size_t TCPOutConnectionManager::s_maxIdlePerAuth;
34	size_t TCPOutConnectionManager::s_maxIdlePerThread;
35
36	void TCPOutConnectionManager::cleanup(const struct timeval& now)
37	{	690✔
38	if (s_maxIdleTime.tv_sec == 0 && s_maxIdleTime.tv_usec == 0) {	690!
39	// no maximum idle time
40	return;	×
41	}	×
42
43	for (auto it = d_idle_connections.begin(); it != d_idle_connections.end();) {	691✔
44	timeval idle = now - it->second.d_last_used;	1✔
45	if (s_maxIdleTime < idle) {	1!
46	it = d_idle_connections.erase(it);	1✔
47	}	1✔
UNCOV 48	else {	×
UNCOV 49	++it;	×
UNCOV 50	}	×
51	}	1✔
52	}	690✔
53
54	void TCPOutConnectionManager::store(const struct timeval& now, const ComboAddress& ip, Connection&& connection)
55	{	13✔
56	++connection.d_numqueries;	13✔
57	if (s_maxQueries > 0 && connection.d_numqueries >= s_maxQueries) {	13!
58	return;	×
59	}	×
60
61	if (d_idle_connections.size() >= s_maxIdlePerThread \|\| d_idle_connections.count(ip) >= s_maxIdlePerAuth) {	13!
62	cleanup(now);	×
63	}	×
64
65	if (d_idle_connections.size() >= s_maxIdlePerThread) {	13!
66	return;	×
67	}	×
68	if (d_idle_connections.count(ip) >= s_maxIdlePerAuth) {	13!
69	return;	×
70	}	×
71
72	gettimeofday(&connection.d_last_used, nullptr);	13✔
73	d_idle_connections.emplace(ip, std::move(connection));	13✔
74	}	13✔
75
76	TCPOutConnectionManager::Connection TCPOutConnectionManager::get(const ComboAddress& ip)
77	{	13✔
78	if (d_idle_connections.count(ip) > 0) {	13✔
79	auto h = d_idle_connections.extract(ip);	6✔
80	return h.mapped();	6✔
81	}	6✔
82	return Connection{};	7✔
83	}	13✔
84
85	uint64_t getCurrentIdleTCPConnections()
86	{	154✔
87	return broadcastAccFunction<uint64_t>([] { return t_tcp_manager.getSize(); });	850✔
88	}	154✔

PowerDNS / pdns / 9988626377

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous