couchbase / sync_gateway / 88
65%
master: 64%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 1
Files 222
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 64.704% (-0.05%) from 64.757%
88

push

jenkins

web-flow 
CBG-4025 Invalidate user roles after resync (#6942)

* CBG-4025 Invalidate user roles after resync

As part of this change, modified access invalidation functions to perform invalidation in a single update to the principal document, instead of once per collection (and one additional time for roles).  To support this:
- Switched existing invalidation functions (invalRoleChannels, invalUserChannels, etc) to have *DatabaseContext receiver instead of *DatabaseCollection, and added a ScopeAndCollectionNames parameter to specify the set of collections that should have access invalidated.
- For ease of use, maintained the existing invalidation functions on *DatabaseCollection - they now just call in to the *DatabaseContext functions with their single collection
- Added a new invalUserRolesAndChannels to invalidate a user’s roles and channels in a single user doc update.  Only currently used by resync

Query based resync still processes a single collection’s updates at a time - it’s structured a bit differently and didn’t seem to be worth refactoring at this point.  It has been updated to properly invalidate user roles.

The new test TestResyncInvalidatePrincipals covers the fix - have verified it with SG_TEST_USE_DEFAULT_COLLECTION=true/false.  Also made a test utility change to remove the password parameter from GetRolePayload since roles don’t have passwords.

* Lint fixes

91 of 118 new or added lines in 7 files covered. (77.12%)

50 existing lines in 11 files now uncovered.

35228 of 54445 relevant lines covered (64.7%)

0.74 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
31.58
 -0.22% db/background_mgr_resync_dcp.go
3
66.63
 -0.15% db/database.go
21
80.0
 -0.75% auth/auth.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
66.63
 -0.15% db/database.go
1
80.0
 -0.75% auth/auth.go
2
89.3
 0.02% db/database_collection.go
2
81.48
 -0.74% base/logging.go
2
90.13
 -0.66% db/active_replicator_common.go
3
95.08
 -4.92% channels/active_channels.go
4
87.58
 -0.89% db/active_replicator_checkpointer.go
5
77.27
 -0.95% db/blip_sync_context.go
7
74.4
 -0.48% rest/config.go
9
70.94
 -1.54% rest/config_manager.go
14
85.07
 -1.12% db/changes.go
Jobs
ID Job ID Ran Files Coverage
1 88.1 222
64.7
Source Files on build 88