9400247089

Committed 06 Jun 2024 11:43AM UTC coverage: 64.595% (-0.03%) from 64.624%

Build # 9400247089

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #14270 from rgacogne/ddist-fix-tcp-worker-error-message

dnsdist: Fix 'Error creating TCP worker' error message

Run Details

37067 of 88168 branches covered (42.04%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

77 existing lines in 17 files now uncovered.

124349 of 161720 relevant lines covered (76.89%)

4702515.08 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

54.26

/pdns/remote_logger.cc

#include <unistd.h>
#include "threadname.hh"
#include "remote_logger.hh"
#include <sys/uio.h>
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#ifdef PDNS_CONFIG_ARGS
#include "logger.hh"
#define WE_ARE_RECURSOR
#else
#include "dolog.hh"
#endif
#include "logging.hh"

bool CircularWriteBuffer::hasRoomFor(const std::string& str) const
{
  if (d_buffer.size() + 2 + str.size() > d_buffer.capacity()) {
    return false;
  }

  return true;
}

bool CircularWriteBuffer::write(const std::string& str)
{
  if (str.size() > std::numeric_limits<uint16_t>::max() || !hasRoomFor(str)) {
    return false;
  }

  uint16_t len = htons(str.size());
  const char* ptr = reinterpret_cast<const char*>(&len);
  d_buffer.insert(d_buffer.end(), ptr, ptr + 2);
  d_buffer.insert(d_buffer.end(), str.begin(), str.end());

  return true;
}

bool CircularWriteBuffer::flush(int fd)
{
  if (d_buffer.empty()) {
    // not optional, we report EOF otherwise
    return false;
  }

  auto arr1 = d_buffer.array_one();
  auto arr2 = d_buffer.array_two();

  struct iovec iov[2];
  int pos = 0;
  for(const auto& arr : {arr1, arr2}) {
    if(arr.second) {
      iov[pos].iov_base = arr.first;
      iov[pos].iov_len = arr.second;
      ++pos;
    }
  }

  ssize_t res = 0;
  do {
    res = writev(fd, iov, pos);

    if (res < 0) {
      if (errno == EINTR) {
        continue;
      }

      if (errno == EAGAIN || errno == EWOULDBLOCK) {
        return false;
      }

      /* we can't be sure we haven't sent a partial message,
         and we don't want to send the remaining part after reconnecting */
      d_buffer.clear();
      throw std::runtime_error("Couldn't flush a thing: " + stringerror());
    }
    else if (!res) {
      /* we can't be sure we haven't sent a partial message,
         and we don't want to send the remaining part after reconnecting */
      d_buffer.clear();
      throw std::runtime_error("EOF");
    }
  }
  while (res < 0);

  if (static_cast<size_t>(res) == d_buffer.size()) {
    d_buffer.clear();
  }
  else {
    while (res--) {
      d_buffer.pop_front();
    }
  }

  return true;
}

const std::string& RemoteLoggerInterface::toErrorString(Result r)
{
  static const std::array<std::string,5> str = {
    "Queued",
    "Queue full, dropping",
    "Not sending too large protobuf message",
    "Submiting to queue failed",
    "?"
  };
  auto i = static_cast<unsigned int>(r);
  return str[std::min(i, 4U)];
}

RemoteLogger::RemoteLogger(const ComboAddress& remote, uint16_t timeout, uint64_t maxQueuedBytes, uint8_t reconnectWaitTime, bool asyncConnect): d_remote(remote), d_timeout(timeout), d_reconnectWaitTime(reconnectWaitTime), d_asyncConnect(asyncConnect), d_runtime({CircularWriteBuffer(maxQueuedBytes), nullptr})
{
  if (!d_asyncConnect) {
    reconnect();
  }

  d_thread = std::thread(&RemoteLogger::maintenanceThread, this);
}

bool RemoteLogger::reconnect()
{
  try {
    auto newSock = make_unique<Socket>(d_remote.sin4.sin_family, SOCK_STREAM, 0);
    newSock->setNonBlocking();
    newSock->connect(d_remote, d_timeout);

    {
      /* we are now successfully connected, time to take the lock and update the
         socket */
      auto runtime = d_runtime.lock();
      runtime->d_socket = std::move(newSock);
    }
  }
  catch (const std::exception& e) {
#ifdef WE_ARE_RECURSOR
    SLOG(g_log<<Logger::Warning<<"Error connecting to remote logger "<<d_remote.toStringWithPort()<<": "<<e.what()<<std::endl,
         g_slog->withName("protobuf")->error(Logr::Error, e.what(), "Exception while connecting to remote logger", "address", Logging::Loggable(d_remote)));
#else
    warnlog("Error connecting to remote logger %s: %s", d_remote.toStringWithPort(), e.what());
#endif

    return false;
  }
  return true;
}

RemoteLoggerInterface::Result RemoteLogger::queueData(const std::string& data)
{
  auto runtime = d_runtime.lock();

  if (data.size() > std::numeric_limits<uint16_t>::max()) {
    ++runtime->d_stats.d_tooLarge;
    return Result::TooLarge;
  }

  if (!runtime->d_writer.hasRoomFor(data)) {
    /* not connected, queue is full, just drop */
    if (!runtime->d_socket) {
      ++runtime->d_stats.d_pipeFull;
      return Result::PipeFull;
    }
    try {
      /* we try to flush some data */
      if (!runtime->d_writer.flush(runtime->d_socket->getHandle())) {
        /* but failed, let's just drop */
        ++runtime->d_stats.d_pipeFull;
        return Result::PipeFull;
      }

      /* see if we freed enough data */
      if (!runtime->d_writer.hasRoomFor(data)) {
        /* we didn't */
        ++runtime->d_stats.d_pipeFull;
        return Result::PipeFull;
      }
    }
    catch(const std::exception& e) {
      //      cout << "Got exception writing: "<<e.what()<<endl;
      runtime->d_socket.reset();
      ++runtime->d_stats.d_otherError;
      return Result::OtherError;
    }
  }

  runtime->d_writer.write(data);
  ++runtime->d_stats.d_queued;
  return Result::Queued;
}

void RemoteLogger::maintenanceThread() 
{
  try {
#ifdef WE_ARE_RECURSOR
    string threadName = "rec/remlog";
#else
    string threadName = "dnsdist/remLog";
#endif
    setThreadName(threadName);

    for (;;) {
      if (d_exiting) {
        break;
      }

      bool connected = true;
      if (d_runtime.lock()->d_socket == nullptr) {
        // if it was unset, it will remain so, we are the only ones setting it!
        connected = reconnect();
      }

      /* we will just go to sleep if the reconnection just failed */
      if (connected) {
        try {
          /* we don't want to take the lock while trying to reconnect */
          auto runtime = d_runtime.lock();
          if (runtime->d_socket) { // check if it is set
            /* if flush() returns false, it means that we couldn't flush anything yet
               either because there is nothing to flush, or because the outgoing TCP
               buffer is full. That's fine by us */
            runtime->d_writer.flush(runtime->d_socket->getHandle());
          }
          else {
            connected = false;
          }
        }
        catch (const std::exception& e) {
          d_runtime.lock()->d_socket.reset();
          connected = false;
        }

        if (!connected) {
          /* let's try to reconnect right away, we are about to sleep anyway */
          reconnect();
        }
      }

      sleep(d_reconnectWaitTime);
    }
  }
  catch (const std::exception& e)
  {
    SLOG(cerr << "Remote Logger's maintenance thread died on: " << e.what() << endl,
         g_slog->withName("protobuf")->error(Logr::Error, e.what(), "Remote Logger's maintenance thread died"));
  }
  catch (...) {
    SLOG(cerr << "Remote Logger's maintenance thread died on unknown exception" << endl,
         g_slog->withName("protobuf")->info(Logr::Error, "Remote Logger's maintenance thread died"));
  }
}

RemoteLogger::~RemoteLogger()
{
  d_exiting = true;

  d_thread.join();
}


1	#include <unistd.h>
2	#include "threadname.hh"
3	#include "remote_logger.hh"
4	#include <sys/uio.h>
5	#ifdef HAVE_CONFIG_H
6	#include "config.h"
7	#endif
8	#ifdef PDNS_CONFIG_ARGS
9	#include "logger.hh"
10	#define WE_ARE_RECURSOR
11	#else
12	#include "dolog.hh"
13	#endif
14	#include "logging.hh"
15
16	bool CircularWriteBuffer::hasRoomFor(const std::string& str) const
17	{	404✔
18	if (d_buffer.size() + 2 + str.size() > d_buffer.capacity()) {	404!
19	return false;	×
20	}	×
21
22	return true;	404✔
23	}	404✔
24
25	bool CircularWriteBuffer::write(const std::string& str)
26	{	202✔
27	if (str.size() > std::numeric_limits<uint16_t>::max() \|\| !hasRoomFor(str)) {	202!
28	return false;	×
29	}	×
30
31	uint16_t len = htons(str.size());	202✔
32	const char* ptr = reinterpret_cast<const char*>(&len);	202✔
33	d_buffer.insert(d_buffer.end(), ptr, ptr + 2);	202✔
34	d_buffer.insert(d_buffer.end(), str.begin(), str.end());	202✔
35
36	return true;	202✔
37	}	202✔
38
39	bool CircularWriteBuffer::flush(int fd)
40	{	841✔
41	if (d_buffer.empty()) {	841✔
42	// not optional, we report EOF otherwise
43	return false;	753✔
44	}	753✔
45
46	auto arr1 = d_buffer.array_one();	88✔
47	auto arr2 = d_buffer.array_two();	88✔
48
49	struct iovec iov[2];	88✔
50	int pos = 0;	88✔
51	for(const auto& arr : {arr1, arr2}) {	180✔
52	if(arr.second) {	180✔
53	iov[pos].iov_base = arr.first;	90✔
54	iov[pos].iov_len = arr.second;	90✔
55	++pos;	90✔
56	}	90✔
57	}	180✔
58
59	ssize_t res = 0;	88✔
60	do {	88✔
61	res = writev(fd, iov, pos);	88✔
62
63	if (res < 0) {	88!
64	if (errno == EINTR) {	×
65	continue;	×
66	}	×
67
68	if (errno == EAGAIN \|\| errno == EWOULDBLOCK) {	×
69	return false;	×
70	}	×
71
72	/* we can't be sure we haven't sent a partial message,
73	and we don't want to send the remaining part after reconnecting */
74	d_buffer.clear();	×
75	throw std::runtime_error("Couldn't flush a thing: " + stringerror());	×
76	}	×
77	else if (!res) {	88!
78	/* we can't be sure we haven't sent a partial message,
79	and we don't want to send the remaining part after reconnecting */
80	d_buffer.clear();	×
81	throw std::runtime_error("EOF");	×
82	}	×
83	}	88✔
84	while (res < 0);	88!
85
86	if (static_cast<size_t>(res) == d_buffer.size()) {	90✔
87	d_buffer.clear();	90✔
88	}	90✔
89	else {	2,147,483,647✔
90	while (res--) {	2,147,483,647!
91	d_buffer.pop_front();	×
92	}	×
93	}	2,147,483,647✔
94
95	return true;	88✔
96	}	88✔
97
98	const std::string& RemoteLoggerInterface::toErrorString(Result r)
99	{	×
100	static const std::array<std::string,5> str = {	×
101	"Queued",	×
102	"Queue full, dropping",	×
103	"Not sending too large protobuf message",	×
104	"Submiting to queue failed",	×
105	"?"	×
106	};	×
107	auto i = static_cast<unsigned int>(r);	×
108	return str[std::min(i, 4U)];	×
109	}	×
110
111	RemoteLogger::RemoteLogger(const ComboAddress& remote, uint16_t timeout, uint64_t maxQueuedBytes, uint8_t reconnectWaitTime, bool asyncConnect): d_remote(remote), d_timeout(timeout), d_reconnectWaitTime(reconnectWaitTime), d_asyncConnect(asyncConnect), d_runtime({CircularWriteBuffer(maxQueuedBytes), nullptr})
112	{	219✔
113	if (!d_asyncConnect) {	219!
114	reconnect();	219✔
115	}	219✔
116
117	d_thread = std::thread(&RemoteLogger::maintenanceThread, this);	219✔
118	}	219✔
119
120	bool RemoteLogger::reconnect()
121	{	219✔
122	try {	219✔
123	auto newSock = make_unique<Socket>(d_remote.sin4.sin_family, SOCK_STREAM, 0);	219✔
124	newSock->setNonBlocking();	219✔
125	newSock->connect(d_remote, d_timeout);	219✔
126
127	{	219✔
128	/* we are now successfully connected, time to take the lock and update the
129	socket */
130	auto runtime = d_runtime.lock();	219✔
131	runtime->d_socket = std::move(newSock);	219✔
132	}	219✔
133	}	219✔
134	catch (const std::exception& e) {	219✔
135	#ifdef WE_ARE_RECURSOR
136	SLOG(g_log<<Logger::Warning<<"Error connecting to remote logger "<<d_remote.toStringWithPort()<<": "<<e.what()<<std::endl,
137	g_slog->withName("protobuf")->error(Logr::Error, e.what(), "Exception while connecting to remote logger", "address", Logging::Loggable(d_remote)));
138	#else
139	warnlog("Error connecting to remote logger %s: %s", d_remote.toStringWithPort(), e.what());
140	#endif
141
142	return false;	×
143	}	×
144	return true;	219✔
145	}	219✔
146
147	RemoteLoggerInterface::Result RemoteLogger::queueData(const std::string& data)
148	{	202✔
149	auto runtime = d_runtime.lock();	202✔
150
151	if (data.size() > std::numeric_limits<uint16_t>::max()) {	202!
152	++runtime->d_stats.d_tooLarge;	×
153	return Result::TooLarge;	×
154	}	×
155
156	if (!runtime->d_writer.hasRoomFor(data)) {	202!
157	/* not connected, queue is full, just drop */
158	if (!runtime->d_socket) {	×
159	++runtime->d_stats.d_pipeFull;	×
160	return Result::PipeFull;	×
161	}	×
162	try {	×
163	/* we try to flush some data */
164	if (!runtime->d_writer.flush(runtime->d_socket->getHandle())) {	×
165	/* but failed, let's just drop */
166	++runtime->d_stats.d_pipeFull;	×
167	return Result::PipeFull;	×
168	}	×
169
170	/* see if we freed enough data */
171	if (!runtime->d_writer.hasRoomFor(data)) {	×
172	/* we didn't */
173	++runtime->d_stats.d_pipeFull;	×
174	return Result::PipeFull;	×
175	}	×
176	}	×
177	catch(const std::exception& e) {	×
178	// cout << "Got exception writing: "<<e.what()<<endl;
179	runtime->d_socket.reset();	×
180	++runtime->d_stats.d_otherError;	×
181	return Result::OtherError;	×
182	}	×
183	}	×
184
185	runtime->d_writer.write(data);	202✔
186	++runtime->d_stats.d_queued;	202✔
187	return Result::Queued;	202✔
188	}	202✔
189
190	void RemoteLogger::maintenanceThread()
191	{	219✔
192	try {	219✔
193	#ifdef WE_ARE_RECURSOR	210✔
194	string threadName = "rec/remlog";	210✔
195	#else
196	string threadName = "dnsdist/remLog";	9✔
197	#endif	9✔
198	setThreadName(threadName);	219✔
199
200	for (;;) {	843✔
201	if (d_exiting) {	843!
202	break;	×
203	}	×
204
205	bool connected = true;	843✔
206	if (d_runtime.lock()->d_socket == nullptr) {	843!
207	// if it was unset, it will remain so, we are the only ones setting it!
208	connected = reconnect();	×
209	}	×
210
211	/* we will just go to sleep if the reconnection just failed */
212	if (connected) {	843✔
213	try {	840✔
214	/* we don't want to take the lock while trying to reconnect */
215	auto runtime = d_runtime.lock();	840✔
216	if (runtime->d_socket) { // check if it is set	840!
217	/* if flush() returns false, it means that we couldn't flush anything yet
218	either because there is nothing to flush, or because the outgoing TCP
219	buffer is full. That's fine by us */
220	runtime->d_writer.flush(runtime->d_socket->getHandle());	840✔
221	}	840✔
UNCOV 222	else {	×
UNCOV 223	connected = false;	×
UNCOV 224	}	×
225	}	840✔
226	catch (const std::exception& e) {	840✔
227	d_runtime.lock()->d_socket.reset();	×
228	connected = false;	×
229	}	×
230
231	if (!connected) {	842!
232	/* let's try to reconnect right away, we are about to sleep anyway */
233	reconnect();	×
234	}	×
235	}	842✔
236
237	sleep(d_reconnectWaitTime);	845✔
238	}	845✔
239	}	219✔
240	catch (const std::exception& e)	219✔
241	{	219✔
242	SLOG(cerr << "Remote Logger's maintenance thread died on: " << e.what() << endl,	×
243	g_slog->withName("protobuf")->error(Logr::Error, e.what(), "Remote Logger's maintenance thread died"));	×
244	}	×
245	catch (...) {	219✔
246	SLOG(cerr << "Remote Logger's maintenance thread died on unknown exception" << endl,	×
247	g_slog->withName("protobuf")->info(Logr::Error, "Remote Logger's maintenance thread died"));	×
248	}	×
249	}	219✔
250
251	RemoteLogger::~RemoteLogger()
252	{	×
253	d_exiting = true;	×
254
255	d_thread.join();	×
256	}	×
257

PowerDNS / pdns / 9400247089

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous