uber / cadence-java-client / 2307

61%

master: 80%

Pull #890

buildkite

Lock TestWorkflowStoreImpl when listing workflows

This is the only path to the backing histories map that isn't locked. When running a test containing multiple child workflows in parallel where one child workflow attempts to call listWorkflows I'm able to consistently reproduce a concurrent modification exception.

Despite being a change to locking, this change is rather low risk. The lock is reentrant and there are no other locks acquired while holding this lock, so there's no chance of deadlock. In addition, this codepath isn't use internally at all. It exists only to implement ListOpenWorkflowExecutions and ListClosedWorkflowExecutions on the client, allowing test code to make these RPCs. This is likely why it hasn't been caught before.

43 of 46 new or added lines in 1 file covered. (93.48%)

11953 of 19459 relevant lines covered (61.43%)

0.61 hits per line