b64ccf90-3eb9-40db-90cd-aae716a7876e

Committed 10 Apr 2024 02:02PM UTC coverage: 68.795%. Remained the same

Build # b64ccf90-3eb9-40db-90cd-aae716a7876e

Build Type

push

circleci

Committed by

symroe

Commit Message

Remove some reports, add common names

Run Details

1775 of 2995 branches covered (59.27%)

Branch coverage included in aggregate %.

7 of 9 new or added lines in 1 file covered. (77.78%)

194 existing lines in 2 files now uncovered.

7328 of 10237 relevant lines covered (71.58%)

0.72 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.21

/ynr/apps/cached_counts/views.py

import json
from typing import Tuple, Type

from candidates.models import Ballot
from django.db.models import Count
from django.http import Http404, HttpResponse
from django.views.generic import DetailView, TemplateView
from elections.mixins import ElectionMixin
from elections.models import Election
from parties.models import Party
from popolo.models import Membership

from .models import ElectionReport, get_attention_needed_posts
from .report_helpers import (
    BallotsContestedPerParty,
    BaseReport,
    CandidatesPerParty,
    CommonFirstNames,
    CommonLastNames,
    MostPerSeat,
    NcandidatesPerSeat,
    NewParties,
    NumberOfBallots,
    NumberOfCandidates,
    NumberOfSeats,
    NumCandidatesStandingInMultipleSeats,
    PartyMovers,
    TwoWayRace,
    TwoWayRaceForNcandidates,
    TwoWayRaceForNewParties,
    UncontestedBallots,
)


def get_counts(for_json=True):
    election_id_to_candidates = {}
    qs = (
        Membership.objects.all()
        .values("ballot__election")
        .annotate(count=Count("ballot__election"))
        .order_by()
    )

    for d in qs:
        election_id_to_candidates[d["ballot__election"]] = d["count"]

    grouped_elections = Election.group_and_order_elections(for_json=for_json)
    for era_data in grouped_elections:
        for date, elections in era_data["dates"].items():
            for role_data in elections:
                for election_data in role_data["elections"]:
                    e = election_data["election"]
                    total = election_id_to_candidates.get(e.id, 0)
                    election_counts = {
                        "id": e.slug,
                        "html_id": e.slug.replace(".", "-"),
                        "name": e.name,
                        "total": total,
                    }
                    election_data.update(election_counts)
                    del election_data["election"]
    return grouped_elections


class ReportsHomeView(TemplateView):
    template_name = "reports.html"

    def get_context_data(self, **kwargs):
        context = super().get_context_data(**kwargs)
        context["all_elections"] = get_counts()
        return context

    def get(self, *args, **kwargs):
        if self.request.GET.get("format") == "json":
            return HttpResponse(
                json.dumps(get_counts(for_json=True)),
                content_type="application/json",
            )
        return super().get(*args, **kwargs)


class PartyCountsView(ElectionMixin, TemplateView):
    template_name = "party_counts.html"

    def get_context_data(self, **kwargs):
        context = super().get_context_data(**kwargs)
        qs = Party.objects.filter(
            membership__ballot__election=self.election_data
        )
        qs = qs.annotate(count=Count("membership"))
        qs = qs.order_by("-count", "name")

        context["party_counts"] = qs

        return context


class ConstituencyCountsView(ElectionMixin, TemplateView):
    template_name = "constituency_counts.html"

    def get_context_data(self, **kwargs):
        context = super().get_context_data(**kwargs)
        qs = Ballot.objects.filter(election=self.election_data).annotate(
            count=Count("membership")
        )
        qs = qs.select_related("post", "election")
        qs = qs.order_by("-count")

        context["post_counts"] = qs
        return context


class AttentionNeededView(TemplateView):
    template_name = "attention_needed.html"

    def get_context_data(self, **kwargs):
        context = super().get_context_data(**kwargs)
        context["post_counts"] = get_attention_needed_posts()
        return context


DEFAULT_REPORTS: Tuple[Type[BaseReport]] = (
    NumberOfCandidates,
    NumberOfBallots,
    NumberOfSeats,
    CandidatesPerParty,
    BallotsContestedPerParty,
    UncontestedBallots,
    NcandidatesPerSeat,
    TwoWayRace,
    TwoWayRaceForNewParties,
    TwoWayRaceForNcandidates,
    MostPerSeat,
    NewParties,
    PartyMovers,
    NumCandidatesStandingInMultipleSeats,
    CommonFirstNames,
    CommonLastNames,
)


class ElectionReportView(DetailView):
    model = ElectionReport

    def get_object(self, queryset=None):
        election_type, election_date = self.kwargs["report_slug"].split("-", 1)
        qs = self.model.objects.filter(
            election_type=election_type,
            election_date=election_date,
        )
        try:
            return qs.get()
        except self.model.DoesNotExist:
            raise Http404("Report not found")

    template_name = "cached_counts/election-report.html"

    def get_context_data(self, **kwargs):
        context = super().get_context_data(**kwargs)

        context["reports"] = {}

        for report_klass in DEFAULT_REPORTS:
            report = report_klass(
                str(self.object.election_date),
                election_type=self.object.election_type,
            )
            report.run()
            context["reports"][report.__class__.__name__] = report

        return context

1	import json	1✔
2	from typing import Tuple, Type	1✔
3
4	from candidates.models import Ballot	1✔
5	from django.db.models import Count	1✔
6	from django.http import Http404, HttpResponse	1✔
7	from django.views.generic import DetailView, TemplateView	1✔
8	from elections.mixins import ElectionMixin	1✔
9	from elections.models import Election	1✔
10	from parties.models import Party	1✔
11	from popolo.models import Membership	1✔
12
13	from .models import ElectionReport, get_attention_needed_posts	1✔
14	from .report_helpers import (	1✔
15	BallotsContestedPerParty,
16	BaseReport,
17	CandidatesPerParty,
18	CommonFirstNames,
19	CommonLastNames,
20	MostPerSeat,
21	NcandidatesPerSeat,
22	NewParties,
23	NumberOfBallots,
24	NumberOfCandidates,
25	NumberOfSeats,
26	NumCandidatesStandingInMultipleSeats,
27	PartyMovers,
28	TwoWayRace,
29	TwoWayRaceForNcandidates,
30	TwoWayRaceForNewParties,
31	UncontestedBallots,
32	)
33
34
35	def get_counts(for_json=True):	1✔
36	election_id_to_candidates = {}	1✔
37	qs = (	1✔
38	Membership.objects.all()
39	.values("ballot__election")
40	.annotate(count=Count("ballot__election"))
41	.order_by()
42	)
43
44	for d in qs:	1✔
45	election_id_to_candidates[d["ballot__election"]] = d["count"]	1✔
46
47	grouped_elections = Election.group_and_order_elections(for_json=for_json)	1✔
48	for era_data in grouped_elections:	1✔
49	for date, elections in era_data["dates"].items():	1✔
50	for role_data in elections:	1✔
51	for election_data in role_data["elections"]:	1✔
52	e = election_data["election"]	1✔
53	total = election_id_to_candidates.get(e.id, 0)	1✔
54	election_counts = {	1✔
55	"id": e.slug,
56	"html_id": e.slug.replace(".", "-"),
57	"name": e.name,
58	"total": total,
59	}
60	election_data.update(election_counts)	1✔
61	del election_data["election"]	1✔
62	return grouped_elections	1✔
63
64
65	class ReportsHomeView(TemplateView):	1✔
66	template_name = "reports.html"	1✔
67
68	def get_context_data(self, **kwargs):	1✔
69	context = super().get_context_data(**kwargs)	1✔
70	context["all_elections"] = get_counts()	1✔
71	return context	1✔
72
73	def get(self, args, *kwargs):	1✔
74	if self.request.GET.get("format") == "json":	1✔
75	return HttpResponse(	1✔
76	json.dumps(get_counts(for_json=True)),
77	content_type="application/json",
78	)
79	return super().get(args, *kwargs)	1✔
80
81
82	class PartyCountsView(ElectionMixin, TemplateView):	1✔
83	template_name = "party_counts.html"	1✔
84
85	def get_context_data(self, **kwargs):	1✔
86	context = super().get_context_data(**kwargs)	1✔
87	qs = Party.objects.filter(	1✔
88	membership__ballot__election=self.election_data
89	)
90	qs = qs.annotate(count=Count("membership"))	1✔
91	qs = qs.order_by("-count", "name")	1✔
92
93	context["party_counts"] = qs	1✔
94
95	return context	1✔
96
97
98	class ConstituencyCountsView(ElectionMixin, TemplateView):	1✔
99	template_name = "constituency_counts.html"	1✔
100
101	def get_context_data(self, **kwargs):	1✔
102	context = super().get_context_data(**kwargs)	1✔
103	qs = Ballot.objects.filter(election=self.election_data).annotate(	1✔
104	count=Count("membership")
105	)
106	qs = qs.select_related("post", "election")	1✔
107	qs = qs.order_by("-count")	1✔
108
109	context["post_counts"] = qs	1✔
110	return context	1✔
111
112
113	class AttentionNeededView(TemplateView):	1✔
114	template_name = "attention_needed.html"	1✔
115
116	def get_context_data(self, **kwargs):	1✔
117	context = super().get_context_data(**kwargs)	1✔
118	context["post_counts"] = get_attention_needed_posts()	1✔
119	return context	1✔
120
121
122	DEFAULT_REPORTS: Tuple[Type[BaseReport]] = (	1✔
123	NumberOfCandidates,
124	NumberOfBallots,
125	NumberOfSeats,
126	CandidatesPerParty,
127	BallotsContestedPerParty,
128	UncontestedBallots,
129	NcandidatesPerSeat,
130	TwoWayRace,
131	TwoWayRaceForNewParties,
132	TwoWayRaceForNcandidates,
133	MostPerSeat,
134	NewParties,
135	PartyMovers,
136	NumCandidatesStandingInMultipleSeats,
137	CommonFirstNames,
138	CommonLastNames,
139	)
140
141
142	class ElectionReportView(DetailView):	1✔
143	model = ElectionReport	1✔
144
145	def get_object(self, queryset=None):	1✔
UNCOV 146	election_type, election_date = self.kwargs["report_slug"].split("-", 1)	×
UNCOV 147	qs = self.model.objects.filter(	×
148	election_type=election_type,
149	election_date=election_date,
150	)
151	try:	×
UNCOV 152	return qs.get()	×
UNCOV 153	except self.model.DoesNotExist:	×
UNCOV 154	raise Http404("Report not found")	×
155
156	template_name = "cached_counts/election-report.html"	1✔
157
158	def get_context_data(self, **kwargs):	1✔
UNCOV 159	context = super().get_context_data(**kwargs)	×
160
UNCOV 161	context["reports"] = {}	×
162
163	for report_klass in DEFAULT_REPORTS:	×
UNCOV 164	report = report_klass(	×
165	str(self.object.election_date),
166	election_type=self.object.election_type,
167	)
168	report.run()	×
UNCOV 169	context["reports"][report.__class__.__name__] = report	×
170
UNCOV 171	return context	×

DemocracyClub / yournextrepresentative / b64ccf90-3eb9-40db-90cd-aae716a7876e

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous