seatgeek / sixpack / 672

pending completion

Build # 672

Build Type

Pull #239

travis-ci

Committed by

web-flow

Commit Message

Ensure atomic experiment creation.

The transaction wrapping the creation of experiment keys in
Experiment.save did not watch any of those keys.  Consequently
parallel writers could cause duplicate writes against an
experiment's mutable values, such as its alternatives list.

This adds a watch guard to the experiment's key. Note that
Experiment.is_new_record now checks the existence of the
experiment's key rather than its membership in the experiments
set; this is so that the code watches a value unique to the
experiment and not one shared by all.

On conflict the experiment's traffic fraction is persisted.

Pull Request Pull Request #239: Ensure atomic experiment creation.

Run Details

1239 of 1543 relevant lines covered (80.3%)

0.8 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.14

sixpack/test/experiment_model_test.py

Build SHA Not Found

The commit SHA "2ecc9f67400538b50706d03f7cc051c83f64c588" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

seatgeek / sixpack / 672

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous