270
98%

Ran 28 Mar 2016 11:23PM UTC

Jobs 1

Files 1

Run time 0s

Badge

Embed ▾

pending completion

Build # 270

Build Type

Pull #234

travis-ci

Committed by

janpaul123

Commit Message

Fix stopListening when changing a prop of type "state"

We used to just call `this.stopListening` on a property of type
"state" whenever we changed it out for some other object. However,
this also unbinds any other listeners on that object, unexpectedly.

Instead, we should keep a reference to the handler, which we do by
changing `_getEventBubblingHandler` into
`_getCachedEventBubblingHandler` and saving it for the `propertyName`.
This way, we can unbind just the handler we just set, and leave other
event listeners untouched.

Pull Request Pull Request #234: Fix stopListening when changing a prop of type "state"

Run Details

389 of 398 relevant lines covered (97.74%)

174.45 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
9	97.74	0.02%	ampersand-state.js

Jobs

ID	Job ID	Ran	Files	Coverage
1	270.1	28 Mar 2016 11:23PM UTC	1	97.74	Travis Job 270.1

Source Files on build 270

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

AmpersandJS / ampersand-state / 270
98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 270

AmpersandJS / ampersand-state / 270 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 270

AmpersandJS / ampersand-state / 270
98%

README BADGES
x