nose-devs / nose2 / 473

pending completion

Build # 473

Build Type

Pull #288

travis-ci

Committed by

jmoldow

Commit Message

Prevent crashing from UnicodeDecodeError

On Python 2, `sys.stdout` and `print` can normally handle any
combination of `str` and `unicode` objects. However,
`StringIO.StringIO` can only safely handle one or the other.  If
the program writes both a non-ASCII `unicode` string, and a
non-ASCII `str` string, then the `getvalue()` method will fail
with `UnicodeDecodeError` [1].

If `nose2.plugins.buffer` (which captures writes to `sys.stdout`
in a `StringIO.StringIO`) is being used, that combination of
writes, followed by a test failure, causes the script to
suddenly abort, with the cryptic `UnicodeDecodeError`.

This fix catches `UnicodeError` when trying to get the captured
output, and will replace the captured output with a warning
message.

This bug is equivalent to nose-devs/nose#816 [2].

[1] <https://github.com/python/cpython/blob/2.7/Lib/StringIO.py#L258>
[2] <https://github.com/nose-devs/nose/issues/816>

Pull Request Pull Request #288: Prevent crashing from UnicodeDecodeError

Run Details

14 of 14 new or added lines in 1 file covered. (100.0%)

3267 of 3823 relevant lines covered (85.46%)

5.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.16

/nose2/plugins/buffer.py

Build SHA Not Found

The commit SHA "0ea8a2d800f203824ed96399fe5df5c182ddc5f3" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

nose-devs / nose2 / 473

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous