nose-devs / nose2 / 473

88%

Pull #288

travis-ci

Prevent crashing from UnicodeDecodeError

On Python 2, `sys.stdout` and `print` can normally handle any
combination of `str` and `unicode` objects. However,
`StringIO.StringIO` can only safely handle one or the other.  If
the program writes both a non-ASCII `unicode` string, and a
non-ASCII `str` string, then the `getvalue()` method will fail
with `UnicodeDecodeError` [1].

If `nose2.plugins.buffer` (which captures writes to `sys.stdout`
in a `StringIO.StringIO`) is being used, that combination of
writes, followed by a test failure, causes the script to
suddenly abort, with the cryptic `UnicodeDecodeError`.

This fix catches `UnicodeError` when trying to get the captured
output, and will replace the captured output with a warning
message.

This bug is equivalent to nose-devs/nose#816 [2].

[1] <https://github.com/python/cpython/blob/2.7/Lib/StringIO.py#L258>
[2] <https://github.com/nose-devs/nose/issues/816>

14 of 14 new or added lines in 1 file covered. (100.0%)

3267 of 3823 relevant lines covered (85.46%)

5.84 hits per line