1081
88%

Ran 29 Feb 2016 09:32PM UTC

Jobs 3

Files 40

Run time 4min

Badge

Embed ▾

pending completion

Build # 1081

Build Type

Pull #234

travis-ci

Committed by

prashantv

Commit Message

Fix bug causing TestCloseSingleChannel to fail

There was a very subtle bug when a connection is closed right after a
successful call is received.
recvPeerFrame was blocked in select {recvCh, errCh}. When a connection
reads a frame, puts it into the recvCh, but then gets an EOF and puts
an EOF error in the errCh, the select will randomly choose a case.
There is no priority order.

In our case, we want a strict priority order when reading frames to
always choose recvCh if there's any frames, and process errors after.
Emulate a priority order by checking recvCh in the errCh case using
a non-blocking select (both on the writer and reader side).

Pull Request Pull Request #234: Unblock calls on connection errors or if the stream has ended

Run Details

3056 of 3751 relevant lines covered (81.47%)

5157.83 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1081.1	29 Feb 2016 09:32PM UTC	40	81.05	Travis Job 1081.1
2	1081.2	29 Feb 2016 09:33PM UTC	40	80.95	Travis Job 1081.2
3	1081.3	29 Feb 2016 09:37PM UTC	40	81.19	Travis Job 1081.3

Source Files on build 1081

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

uber / tchannel-go / 1081
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1081

uber / tchannel-go / 1081 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1081

uber / tchannel-go / 1081
88%

README BADGES
x