zalando-stups / senza / 562

pending completion

Build # 562

Build Type

Pull #171

travis-ci

Committed by

CyberDem0n

Commit Message

Explicitly cast value of Autoscaling Minimum and DesiredCapacity to integer

We wanted to parametrize Minimum and Maximum values of AutoScaling
section to be able to specify them from command line and run into the
following problem:
  File
  "/usr/local/lib/python3.5/dist-packages/senza/components/auto_scaling_group.py",
       line 150, in component_auto_scaling_group
    as_conf.get('DesiredCapacity', 1))
  TypeError: unorderable types: int() > str()

This happens bacause Minimum was specified as a string in a yaml file
and AutoScaling was not specified at all (default = 1)

To avoid this situation we should explicitly cast Minimum and
DesiredCapacity to integer before passing them to `max` function.

Pull Request Pull Request #171: Explicitly cast value of Autoscaling Minimum and DesiredCapacity to integer

Run Details

11 of 11 new or added lines in 1 file covered. (100.0%)

1772 of 2063 relevant lines covered (85.89%)

1.72 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.13

/senza/components/auto_scaling_group.py

Build SHA Not Found

The commit SHA "58f9b358ee93f9eefcfc8197171a26180637cc2b" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

zalando-stups / senza / 562

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous