zalando-stups / senza / 562

90%

Pull #171

travis-ci

Explicitly cast value of Autoscaling Minimum and DesiredCapacity to integer

We wanted to parametrize Minimum and Maximum values of AutoScaling
section to be able to specify them from command line and run into the
following problem:
  File
  "/usr/local/lib/python3.5/dist-packages/senza/components/auto_scaling_group.py",
       line 150, in component_auto_scaling_group
    as_conf.get('DesiredCapacity', 1))
  TypeError: unorderable types: int() > str()

This happens bacause Minimum was specified as a string in a yaml file
and AutoScaling was not specified at all (default = 1)

To avoid this situation we should explicitly cast Minimum and
DesiredCapacity to integer before passing them to `max` function.

11 of 11 new or added lines in 1 file covered. (100.0%)

1772 of 2063 relevant lines covered (85.89%)

1.72 hits per line