#28195

pending completion

Build # #28195

Build Type

push

github

Committed by

web-flow

Commit Message

<a href="https://github.com/api-platform/core/commit/<a class=hub.com/api-platform/core/commit/<a class="double-link" href="https://git"><a class=hub.com/api-platform/core/commit/<a class="double-link" href="https://git"><a class=hub.com/api-platform/core/commit/ee059986d3bdf4805417feaa9bf8ba850f8f0e27">ee059986d<a href="https://github.com/api-platform/core/commit/ee059986d3bdf4805417feaa9bf8ba850f8f0e27">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/api-platform/core/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/api-platform/core/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/api-platform/core/commit/ee059986d3bdf4805417feaa9bf8ba850f8f0e27&quot;&gt;ee059986d&lt;/a&gt;&lt;a href=&quot;https://github.com/api-platform/core/commit/ee059986d3bdf4805417feaa9bf8ba850f8f0e27&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/api-platform/core/commit/ee059986d3bdf4805417feaa9bf8ba85&lt;/a&gt;0f8f0e27">&quot;&gt;Merge &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/api-platform/core/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/api-platform/core/commit/<a class="double-link" href="https://github.com/api-platform/core/commit/fefc7ba1d041d23912f6aeec967112f0fda97deb">fefc7ba1d</a><a href="https://github.com/api-platform/core/commit/ee059986d3bdf4805417feaa9bf8ba850f8f0e27">&amp;quot;&amp;gt;fefc7ba1d&amp;lt;/a&amp;gt;&amp;quot;&amp;gt;fefc7ba1d&amp;lt;/a&amp;gt;&amp;lt;a href=&amp;quot;https://github.com/api-platform/core/commit/ee059986d3bdf4805417feaa9bf8ba850f8f0&lt;/a&gt;e27&quot;&gt; into &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/api-platform/core/commit/<a class="double-link" href="https://github.com/api-platform/core/commit/8cc452c1f">8cc452c1f">8cc452c1f</a>

Run Details

518 of 518 new or added lines in 37 files covered. (100.0%)

13322 of 16817 relevant lines covered (79.22%)

14.61 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

55.0

/src/State/UriVariablesResolverTrait.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\State;

use ApiPlatform\Api\UriVariablesConverterInterface;
use ApiPlatform\Core\Identifier\CompositeIdentifierParser;
use ApiPlatform\Core\Identifier\ContextAwareIdentifierConverterInterface;
use ApiPlatform\Core\Identifier\IdentifierConverterInterface;
use ApiPlatform\Exception\InvalidIdentifierException;
use ApiPlatform\Metadata\Operation;

/**
 * @experimental
 */
trait UriVariablesResolverTrait
{
    /** @var ContextAwareIdentifierConverterInterface|IdentifierConverterInterface|UriVariablesConverterInterface|null */
    private $uriVariablesConverter = null;

    /**
     * Resolves an operation's UriVariables to their identifiers values.
     *
     * @param Operation|null $operation
     */
    private function getOperationIdentifiers($operation, array $parameters, string $resourceClass): array
    {
        $identifiers = [];

        if (!$operation) {
            return $identifiers;
        }

        foreach ($operation->getUriVariables() ?? [] as $parameterName => $uriVariableDefinition) {
            if (!isset($parameters[$parameterName])) {
                if (!isset($parameters['id'])) {
                    throw new InvalidIdentifierException(sprintf('Parameter "%s" not found, check the identifiers configuration.', $parameterName));
                }

                $parameterName = 'id';
            }

            if (($uriVariableDefinition->getCompositeIdentifier() ?? true) && 1 < ($numIdentifiers = \count($uriVariableDefinition->getIdentifiers() ?? []))) {
                $currentIdentifiers = CompositeIdentifierParser::parse($parameters[$parameterName]);

                if (($foundNumIdentifiers = \count($currentIdentifiers)) !== $numIdentifiers) {
                    throw new InvalidIdentifierException(sprintf('We expected "%s" identifiers and got "%s".', $numIdentifiers, $foundNumIdentifiers));
                }

                foreach ($currentIdentifiers as $key => $value) {
                    $identifiers[$key] = $value;
                }

                continue;
            }

            $identifiers[$parameterName] = $parameters[$parameterName];
        }

        if ($this->uriVariablesConverter) {
            $context = ['operation' => $operation];
            $identifiers = $this->uriVariablesConverter instanceof IdentifierConverterInterface ? $this->uriVariablesConverter->convert($identifiers, $operation->getClass() ?? $resourceClass) : $this->uriVariablesConverter->convert($identifiers, $operation->getClass() ?? $resourceClass, $context);
        }

        return $identifiers;
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\State;
15
16	use ApiPlatform\Api\UriVariablesConverterInterface;
17	use ApiPlatform\Core\Identifier\CompositeIdentifierParser;
18	use ApiPlatform\Core\Identifier\ContextAwareIdentifierConverterInterface;
19	use ApiPlatform\Core\Identifier\IdentifierConverterInterface;
20	use ApiPlatform\Exception\InvalidIdentifierException;
21	use ApiPlatform\Metadata\Operation;
22
23	/**
24	* @experimental
25	*/
26	trait UriVariablesResolverTrait
27	{
28	/** @var ContextAwareIdentifierConverterInterface\|IdentifierConverterInterface\|UriVariablesConverterInterface\|null */
29	private $uriVariablesConverter = null;
30
31	/**
32	* Resolves an operation's UriVariables to their identifiers values.
33	*
34	* @param Operation\|null $operation
35	*/
36	private function getOperationIdentifiers($operation, array $parameters, string $resourceClass): array
37	{
38	$identifiers = [];	19✔
39
40	if (!$operation) {	19✔
41	return $identifiers;	3✔
42	}
43
44	foreach ($operation->getUriVariables() ?? [] as $parameterName => $uriVariableDefinition) {	16✔
45	if (!isset($parameters[$parameterName])) {	4✔
46	if (!isset($parameters['id'])) {	1✔
47	throw new InvalidIdentifierException(sprintf('Parameter "%s" not found, check the identifiers configuration.', $parameterName));	1✔
48	}
49
50	$parameterName = 'id';	×
51	}
52
53	if (($uriVariableDefinition->getCompositeIdentifier() ?? true) && 1 < ($numIdentifiers = \count($uriVariableDefinition->getIdentifiers() ?? []))) {	3✔
54	$currentIdentifiers = CompositeIdentifierParser::parse($parameters[$parameterName]);	×
55
56	if (($foundNumIdentifiers = \count($currentIdentifiers)) !== $numIdentifiers) {	×
57	throw new InvalidIdentifierException(sprintf('We expected "%s" identifiers and got "%s".', $numIdentifiers, $foundNumIdentifiers));	×
58	}
59
60	foreach ($currentIdentifiers as $key => $value) {	×
61	$identifiers[$key] = $value;	×
62	}
63
64	continue;	×
65	}
66
67	$identifiers[$parameterName] = $parameters[$parameterName];	3✔
68	}
69
70	if ($this->uriVariablesConverter) {	15✔
71	$context = ['operation' => $operation];	×
72	$identifiers = $this->uriVariablesConverter instanceof IdentifierConverterInterface ? $this->uriVariablesConverter->convert($identifiers, $operation->getClass() ?? $resourceClass) : $this->uriVariablesConverter->convert($identifiers, $operation->getClass() ?? $resourceClass, $context);	×
73	}
74
75	return $identifiers;	15✔
76	}
77	}

api-platform / core / #28195

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous