300
93%

Ran 21 Dec 2013 04:25AM UTC

Jobs 2

Files 45

Run time –

Badge

Embed ▾

pending completion

Build # 300

Build Type

Pull #135

travis-ci

Committed by

manuakasam

Commit Message

Allowing assertions to work :)

The UnitTests for Assertions clearly need some love, but i won't get to that anymore today :( Assertions never worked to begin with as you've always just returned the false case scenario, the assertion check never returned true.

Alternatively to the above `(bool) $assertion` schema we could do a more explicit return, too, which may be a bit better as far as verbosity and less magic goes, like this:

```php
if (is_callable($assertion)) {
    if (true === $assertion($identity)) {
        return true;
    } 
    return false;
} elseif ($assertion instanceof AssertionInterface) {
    if (true === $assertion->assert($identity)) {
        return true;
    }
    return false;
}
```

This way the AuthService would only return true for assertions if the assertion really returns the boolean value `true`. The PR would allow for non boolean values to be returned and be converted using the boolean operator `(bool)`. Personally I would be totally fine with that but this is up for you to decide ;)

Pull Request Pull Request #135: Allowing assertions to work :)

Run Details

407 of 428 relevant lines covered (95.09%)

13.76 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	300.1	21 Dec 2013 04:25AM UTC	45	95.09	Travis Job 300.1
2	300.2	21 Dec 2013 04:26AM UTC	45	95.09	Travis Job 300.2

Source Files on build 300

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

ZF-Commons / zfc-rbac / 300
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 300

ZF-Commons / zfc-rbac / 300 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 300

ZF-Commons / zfc-rbac / 300
93%

README BADGES
x