twitter / CocoaSPDY / 307

pending completion

Build # 307

Build Type

Pull #126

travis-ci

Committed by

kgoodier

Commit Message

Defensive code for SPDYSocket crash.

Inside CFStreamCreatePairWithSocketToHost, generally inside either the
constructor or destructor for HostBase, we sometimes see a crash.
Sometimes it is trying to access address 0x0, sometimes free() detects
corruption.

Let's have no references to self during that call, and let's ensure
the hostname is sufficiently retained.

Also, because it's somewhat related, removing an unnecessary extra
reference to the current endpoint. It's available from the endpoint
manager.

Pull Request Pull Request #126: Attempt to fix socket crashes and improve fast fail behavior

Run Details

39 of 39 new or added lines in 2 files covered. (100.0%)

2784 of 3938 relevant lines covered (70.7%)

44.14 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

28.82

/SPDY/SPDYSocket.m

Build SHA Not Found

The commit SHA "bc9e3e94f0e3daad9f64e583ee3fbe4b523da7f1" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

twitter / CocoaSPDY / 307

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous