2313

pending completion

Build # 2313

Build Type

Pull #2655

travis-ci

Committed by

za-creature

Commit Message

Inconsistent rounter behavior

Fixes an inconsistency within the router:

```coffeescript
express = require "express"

app = express()

app.param "num", (req, res, next, value) ->
  if value.match(/[0-9]+/)
    next()
  else
    next("route")


app.param "alpha", (req, res, next, value) ->
  if value.match(/[a-z]+/)
    next()
  else
    next("route")


app.get "/:alpha/:num", (req, res) ->
  # this works for /test/123
  res.status(200).send("Matched Alpha/Num")


app.get "/:alpha/static", (req, res) ->
  # this works for /test/static
  res.status(200).send("Matched Alpha/Static")


app.get "/:num/static", (req, res) ->
  # this works for /123/static
  res.status(200).send("Matched Num/Static")


app.get "/:num/:alpha", (req, res) ->
  # but this doesn't work for /123/asd (generic 'no route matched' 404 error)
  res.status(200).send("Matched Num/Alpha")


app.listen 1234, ->
  console.log("Ready")
```

This could probably be fixed by using a param regexp instead of a function. However there are cases when that's not enough, for example if you're trying to get an object from a database and fall back onto another route if you couldn't find said object.

Pull Request Pull Request #2655: Inconsistent rounter behavior

Run Details

1788 of 1795 relevant lines covered (99.61%)

1669.89 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

99.24

/lib/router/index.js

Build SHA Not Found

The commit SHA "daa88ea2e01f752518fde12846e1832be8025f35" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

strongloop / express / 2313

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous