nats-io / nats-server / 3434

91%

main: 85%

Pull #1003

travis-ci

Better randomize solicited Gateway URL

We used to invoke getURLs() that would return an array constructed
out of a map, so it was assumed that the array would be automatically
randomized. As we know, map iteration is randomized, but not that
much for small arrays.
More over, once we got the array, we would go over this array until
we get a connection. The order in that array was then not changed.

Replaced this with getting a random index in the array we got. The
risk with this approach is that with small array it is possible
that we pick the same URL multiple times and if that url is not
reachable, it may delay the connection.
Alternative would be to shuffle the array in getURLs and keep the
original code in solicitGateway().

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>

27 of 27 new or added lines in 1 file covered. (100.0%)

14989 of 16505 relevant lines covered (90.81%)

78833.28 hits per line