1618

pending completion

Build # 1618

Build Type

push

travis-ci

Committed by

acdha

Commit Message

Replace code copied from django-passwords

The complexity validator was copied from @dstufft’s 
django-passwords project in violation of the license:

https://github.com/dstufft/django-passwords/blob/master/LICENSE

Based on 56f08d282
this might have been an attempt to make it 
compatible with the official Django password 
validation API added in Django 1.9. This commit
changes that to use django-passwords directly and
just wraps the interface slightly.

Run Details

199 of 390 branches covered (51.03%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 2 files covered. (100.0%)

1932 of 2537 relevant lines covered (76.15%)

3.81 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.33

/concordia/validators.py

from django.conf import settings
from django.utils.translation import ugettext_lazy as _
from passwords.validators import ComplexityValidator


class DjangoPasswordsValidator(object):
    """
    Wrapper for the django-passwords complexity validator which is compatible
    with the Django 1.9+ password validation API
    """

    message = _("Must be more complex (%s)")
    code = "complexity"

    def __init__(self):
        self.validator = ComplexityValidator(settings.PASSWORD_COMPLEXITY)

    def get_help_text(self):
        return _("Your password fails to meet our complexity requirements.")

    def validate(self, value, user=None):
        return self.validator(value)

1	from django.conf import settings	5✔
2	from django.utils.translation import ugettext_lazy as _	5✔
3	from passwords.validators import ComplexityValidator	5✔
4
5
6	class DjangoPasswordsValidator(object):	5✔
7	"""
8	Wrapper for the django-passwords complexity validator which is compatible
9	with the Django 1.9+ password validation API
10	"""
11
12	message = _("Must be more complex (%s)")	5✔
13	code = "complexity"	5✔
14
15	def __init__(self):	5✔
16	self.validator = ComplexityValidator(settings.PASSWORD_COMPLEXITY)	5✔
17
18	def get_help_text(self):	5✔
19	return _("Your password fails to meet our complexity requirements.")	×
20
21	def validate(self, value, user=None):	5✔
22	return self.validator(value)	×

LibraryOfCongress / concordia / 1618

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous