wikimedia / restbase-mod-table-cassandra / 369

88%

master: 84%

Pull #78

travis-ci

Add ability to share column families between domains

This patch prefixes a private `_domain` key element to each hash key, which in
turn lets us share a single CF for several domains. With this patch, all but
two listing tests (for titles and revisions) in restbase are passing. This is
the expected consequence of our strategy of using compound primary keys. The
ability to list hash keys can be restored later using secondary indexes.

Also:

- Introduced an `InternalRequest` class and a `_makeInternalRequest` method to
  set up and systematically handle request-related state. This cuts down the
  number of positional parameters drastically and replaces common boilerplate
  in `get()`, `put()`.

- Removed the now-dead `getSchema` and `_getSchema` methods. This
  functionality is now provided by `_makeInternalRequest`.

- Prepared for a removal of the `table` property in queries. Conceptually, the
  logical table is the resource to execute a query on, so should be part of
  the URI rather than the request body.

- Adjusted some tests to reflect the current limitation of no listings on hash
  keys. We could lift this limitation later, as described above.

- Added systematic private attribute stripping (all attributes starting with
  on an underscore) on the way out. This removes the previously-leaking `_del`
  attribute from the output.

- Commented out paging support and the single corresponding test. This code is
  not actually secure (clients can pass in arbitrary paging state), and needs
  an overhaul before we can re-enable paging. See
  https://phabricator.wikimedia.org/T85640.

- Commented out _getSecondaryIndex. This is not currently used, and needs an
  overhaul / rethink.

Next steps:

- Map groups of domains to internal storage domains in `dbu.keyspaceName()`.
  This will actually enable sharing.

Bug: https://phabricator.wikimedia.org/T91188

199 of 199 new or added lines in 4 files covered. (100.0%)

703 of 801 relevant lines covered (87.77%)

78.77 hits per line