spacedecentral / planning-suite / 678

94%

push

travis-ci

[WIP] Projects v1 frontend (#253)

* Create new cached github state in script.js

- Set the initial state to it
- Create a pseudo-enum object to track the status

* Connect the frontend with the script.js cached github object in index.js

- Subscribe to its value and set in the ConnectedApp state
- The github authentication status gets automatically passed to <App /> as props.github.status

* Pass the github status as props into NewProject sidepanel component

* Reimplement render method in NewProject sidepanel:

- Destructure github status from props and showRepos local function
- Replace div with React.Fragment
- Conditionally call showRepos() that renders the repos list, or GithubAuth component, depending on the github status (initial / authenticated)

* FIX: Transform showRepos() to arrow function...

- To bind "this" into the local scope

- Also replace inconsistent error-prone "var"s for "let"s

* Rework GithubAuth component and import it in NewProject panel...

- Remove unused imports
- Convert to stateless functional component
- Receives handleSignIn function prop
- Set handleSignIn as the button onClick event handler
- Replaced div by React.Fragment in render method
- Replace styled-components for inline style (we only use 1 css rule!)
- Comment old unneeded code
- Add note for new possible UX addition/extra option: use personal token

47 of 60 branches covered (78.33%)

Branch coverage included in aggregate %.

248 of 257 relevant lines covered (96.5%)

13.88 hits per line