1462

pending completion

Build # 1462

Build Type

Pull #1333

travis-ci

Committed by

carlsverre

Commit Message

Coroutine exception __context__ leak in python 3

In Python 3 every exception has an auto-attached __context__ exception if it was
raised while an existing exception was being handled.  This is often a very
useful property and allows users to see the underlying cause of many problems.

However, when dealing with async code via coroutines this feature can suddenly
become a pretty big issue.  Namely, if you generator.throw back into a coroutine
to raise an exception in the correct scope, and that coroutine raises an
exception at a later time you can have nested exceptions which shouldn't
logically be nested.

This patch resolves this issue in the coroutine code by moving the gen.throw
outside of the exception handler.  By doing this the user-code scope is able to
later raise exceptions without worrying about inheriting prior exception
context.

Pull Request Pull Request #1333: Coroutine exception __context__ leak in python 3

Run Details

71439 of 84207 relevant lines covered (84.84%)

1.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/home/travis/virtualenv/pypy-2.5.0/site-packages/tornado-4.2.dev1-py2.7.egg/tornado/auth.py

Build SHA Not Found

The commit SHA "273e923d995c94beb5dc4991cf45c74a4b00e41b" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

tornadoweb / tornado / 1462

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous