zendframework / zend-expressive / 1504

93%

master: 97%

Pull #562

travis-ci

Provide a dedicated service for the server request error response generator

Instead of re-using the existing `ErrorResponseGenerator`, this patch
does the following:

- Separates functionality for generating the error response into a
  trait, `Zend\Expressive\Response\ErrorResponseGeneratorTrait`. The
  method `prepareTemplatedResponse()` now expects the error, the
  response, and an array of data to provide to the template.
- Updates `Zend\Expressive\Middleware\ErrorResponseGenerator` to use the
  new trait.
- Creates a new class, `Zend\Expressive\Response\ServerRequestErrorResponseGenerator`,
  which expects a response factory, and optionally the debug flag,
  renderer, and template to render to. It composes the trait, and
  generates a response on-the-fly to pass to the trait methods.

The `RequestHandlerRunnerFactory` has been updated to use this new
service, and the `ServerRequestErrorResponseGeneratorFactory` was
updated to generate an instance of the new class.

These changes mean the constant SERVER_REQUEST_ERROR_RESPONSE_GENERATOR
is no longer needed, and was thus removed.

51 of 51 new or added lines in 4 files covered. (100.0%)

348 of 384 relevant lines covered (90.63%)

10.91 hits per line