omniauth / omniauth / 673

100%

Pull #903

travis-ci

Deal with relative url root installations

This commit allows OmniAuth to handle relative url root installations
by correctly prefixing the default `Strategy#request_path` and
`Strategy#callback_path` with `SCRIPT_NAME` as provided by Rack.

Also, in order to detect the full current path, uses
`Rack::Request#path` instead of `#path_info`, as the latter does not
include SCRIPT_NAME.

A deeper question remains: What should happen with custom callback and
request paths? I can't think of a case where a user with a relative url
root installation would *not* want to prefix its paths, regardless of
setting a custom path or not.
However, since some people may have configured custom paths in order to
deal with relative root, including this change may be breaking.

7 of 7 new or added lines in 1 file covered. (100.0%)

477 of 513 relevant lines covered (92.98%)

92.68 hits per line